Use tokio::oneshot for sim clock #822
Open
+57
−107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D80029571 |
thomasywang
force-pushed
the
export-D80029571
branch
from
5f66215 to
16251b9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D80029571 |
thomasywang
force-pushed
the
export-D80029571
branch
from
16251b9 to
f9de512
Compare
|
This pull request was exported from Phabricator. Differential Revision: D80029571 |
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Aug 14, 2025
Summary: There was an open TODO to remove the global mailbox for SimClock. We don't actually even need mailboxes for sim clock and a oneshot works just fine Differential Revision: D80029571
Summary: buck run fbcode//monarch/examples/meta/paft:actor_paft -- --mesh_type thread --group_size 250 --max_groups 10 --min_healthy 7 Differential Revision: D78917462
thomasywang
force-pushed
the
export-D80029571
branch
from
f9de512 to
311e90d
Compare
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Aug 14, 2025
Summary: There was an open TODO to remove the global mailbox for SimClock. We don't actually even need mailboxes for sim clock and a oneshot works just fine Differential Revision: D80029571
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Aug 14, 2025
Summary: There was an open TODO to remove the global mailbox for SimClock. We don't actually even need mailboxes for sim clock and a oneshot works just fine Differential Revision: D80029571
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Aug 14, 2025
Summary: There was an open TODO to remove the global mailbox for SimClock. We don't actually even need mailboxes for sim clock and a oneshot works just fine Differential Revision: D80029571
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Aug 14, 2025
Summary: There was an open TODO to remove the global mailbox for SimClock. We don't actually even need mailboxes for sim clock and a oneshot works just fine Differential Revision: D80029571
Summary: Pull Request resolved: meta-pytorch#822 There was an open TODO to remove the global mailbox for SimClock. We don't actually even need mailboxes for sim clock and a oneshot works just fine Differential Revision: D80029571
|
This pull request was exported from Phabricator. Differential Revision: D80029571 |
thomasywang
force-pushed
the
export-D80029571
branch
from
311e90d to
fe03ff0
Compare
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Aug 18, 2025
Summary: There was an open TODO to remove the global mailbox for SimClock. We don't actually even need mailboxes for sim clock and a oneshot works just fine Differential Revision: D80029571
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: There was an open TODO to remove the global mailbox for SimClock. We don't actually even need mailboxes for sim clock and a oneshot works just fine
Differential Revision: D80029571